Re: [PATCH 1/3] spi: spi-fsl-lpspi: use min_t() to improve code

[Frank Li]

On Fri, Aug 15, 2025 at 04:21:15PM +0800, Qianfeng Rong wrote:
> Use min_t() to reduce the code in fsl_lpspi_setup_transfer() and
> improve its readability.
>

Nit: No functionality change.

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx>
> ---
>  drivers/spi/spi-fsl-lpspi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> index 313e444a34f3..dbdb9e114022 100644
> --- a/drivers/spi/spi-fsl-lpspi.c
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -25,6 +25,7 @@
>  #include <linux/spi/spi.h>
>  #include <linux/spi/spi_bitbang.h>
>  #include <linux/types.h>
> +#include <linux/minmax.h>
>
>  #define DRIVER_NAME "fsl_lpspi"
>
> @@ -473,10 +474,9 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
>  		fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
>  	}
>
> -	if (t->len <= fsl_lpspi->txfifosize)
> -		fsl_lpspi->watermark = t->len;
> -	else
> -		fsl_lpspi->watermark = fsl_lpspi->txfifosize;
> +	fsl_lpspi->watermark = min_t(typeof(fsl_lpspi->watermark),
> +				     fsl_lpspi->txfifosize,
> +				     t->len);
>
>  	if (fsl_lpspi_can_dma(controller, spi, t))
>  		fsl_lpspi->usedma = true;
> --
> 2.34.1
>