Re: [PATCH] x86/fred: Fix 64bit identifier in fred_ss

[H. Peter Anvin]

On 2025-08-14 12:04, Andrew Cooper wrote:
> FRED can only be enabled in Long Mode.  This is the 64bit mode (as opposed to
> compatibility mode) identifier, rather than being something hard-wired at 1.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

[...]


> IIRC, this was wrong in an older version of the FRED spec.  I made the same
> mistake in Xen, and I didn't copy Linux's structure.
> 
> I don't thinks this warrants backporting, but the fixes tag is:
> 
> Fixes: 3c77bf02d0c0 ("x86/ptrace: Add FRED additional information to the pt_regs structure")

Please make it explicit that this patch is "no functional change", i.e.
it is naming-only patch.

Other than that:

Reviewed-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>