Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: Add clocks for QoS configuration

From: Georgi Djakov
Date: Fri Aug 15 2025 - 09:12:21 EST


On 8/13/25 8:45 AM, Odelu Kukatla wrote:


On 8/12/2025 3:21 PM, Konrad Dybcio wrote:
On 8/8/25 4:03 PM, Odelu Kukatla wrote:
Add register addresses and clocks which need to be enabled for
configuring QoS on sa8775p SoC.

Signed-off-by: Odelu Kukatla <odelu.kukatla@xxxxxxxxxxxxxxxx>
---

[...]

+ system_noc: interconnect@01680000 {

stray leading zero

Thanks for the review, i will address this in next revision.> I also see there's a camera noc.. are these controlled internally
by Titan nowadays?

Yes, camera NoC is controlled internally.
By internally, do you mean that it's controlled by some camera driver? Why the camnoc is not using the interconnect framework?

Thanks,
Georgi