Re: [PATCH v2 1/3] media: qcom: camss: Add support for TPG common

From: Bryan O'Donoghue
Date: Fri Aug 15 2025 - 08:13:45 EST


On 15/08/2025 09:52, Wenmeng Liu wrote:

Which clock is it we are setting here i.e. do we really need to care about the rate at all ?

TPG generally uses the clocks from CSIPHY/CSID/AON. If we can ensure that the clocks required by TPG are enabled in CSID/VFE, then there's no need to configure them in the TPG node.

On Lemans (SA8775P), there's a special case where TPG requires the CAMNOC_AXI to be set to 400 MHz to function properly, while the sensor does not.

No that's fine.

The TPG should list the clocks _it_ depends on without assuming CSID or VFE is running at all.

---
bod