Re: [PATCH] drm/panthor: Remove dead code in mmu_hw_do_operation_locked

From: Steven Price
Date: Fri Aug 15 2025 - 07:25:24 EST


On 15/08/2025 12:17, Daniel Stone wrote:
> Hi Steven,
>
> On Fri, 15 Aug 2025 at 11:25, Steven Price <steven.price@xxxxxxx> wrote:
>> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either
>> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. So remove the code paths
>> that test for other operations and add a drm_WARN_ON() to catch the
>> posibility of others appearing the future.
>
> Thanks! I think it would make sense to also inline
> mmu_hw_do_flush_on_gpu_ctrl() here though.

True, I'll have a go at a proper rewrite of that function to make it
more coherent.

Thanks,
Steve