Re: [PATCH v7 09/13] PCI: Add Cix Technology Vendor and Device ID

[Peter Chen]

On 25-08-14 17:23:58, Bjorn Helgaas wrote:
> EXTERNAL EMAIL
> 
> On Wed, Aug 13, 2025 at 12:23:27PM +0800, hans.zhang@xxxxxxxxxxx wrote:
> > From: Hans Zhang <hans.zhang@xxxxxxxxxxx>
> >
> > Add Cixtech P1 (internal name sky1) as a vendor and device ID for PCI
> > devices. This ID will be used by the CIX Sky1 PCIe host controller driver.
> >
> > Signed-off-by: Hans Zhang <hans.zhang@xxxxxxxxxxx>
> > ---
> >  include/linux/pci_ids.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 92ffc4373f6d..24b04d085920 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2631,6 +2631,9 @@
> >
> >  #define PCI_VENDOR_ID_CXL            0x1e98
> >
> > +#define PCI_VENDOR_ID_CIX            0x1f6c
> > +#define PCI_DEVICE_ID_CIX_SKY1               0x0001
> 
> I only see these used once in this series, so they probably should be
> defined in the file that uses them, per the comment at the top of this
> file.
> 
> Also, https://pcisig.com/membership/member-companies?combine=0x1f6c
> doesn't show 0x1f6c as assigned to CIX.  That database often seems
> incomplete, but please double check to make sure the ID is actually
> reserved.

Hi Bjorn,

Would you please check below:
https://pcisig.com/membership/member-companies?combine=1f6c

-- 

Best regards,
Peter