Re: [PATCH v1] PM: Support aborting suspend during filesystem sync

[Samuel Wu]

On Tue, Aug 12, 2025 at 10:53 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Aug 12, 2025 at 04:21:23PM -0700, Samuel Wu wrote:
> > +static bool suspend_fs_sync_queued;
> > +DEFINE_SPINLOCK(suspend_fs_sync_lock);
> > +DECLARE_COMPLETION(suspend_fs_sync_complete);
> > +void suspend_abort_fs_sync(void)
> > +{
> > +     spin_lock(&suspend_fs_sync_lock);
> > +     complete(&suspend_fs_sync_complete);
> > +     spin_unlock(&suspend_fs_sync_lock);
> > +}
>
> Why no documentation for this public function that you added, but yet
> you added documentation for a static function that no one can call?
>
> thanks,
>
> greg k-h

Thanks for catching this; updated in V2 of patch.

-- Samuel Wu