Re: [PATCH v8 15/32] x86,fs/resctrl: Add an architectural hook called for each mount

[Reinette Chatre]

Hi Tony,

On 8/11/25 11:16 AM, Tony Luck wrote:
> Enumeration of Intel telemetry events is an asyncronnous process involving

"asyncronnous" -> "asynchronous"

> several mutually dependent drivers added as auxiliary devices during
> the device_initcall() phase of Linux boot. The process completes after
> the probe functions for these drivers are called. But this happens after

"for these drivers" -> "of these drivers"?

"are called" -> "completes" or "are run"?
(i.e the probe functions should not just be called but need to finish their
work?)

> resctrl_arch_late_init() is executed.
> 
> Tracing the enumeration process shows that it does complete a full seven
> seconds before the earliest possible mount of the resctrl file system
> (when included in /etc/fstab for automatic mount by systemd).
> 
> Add a hook at the beginning of the mount code that will be used
> to check for telemetry events and initialize if any are found.
> 
> Call the hook on every attempted mount. But expectations are that

"But expectations" -> "Expectations"

> most actions (like enumeration) will only need to be performed
> on the first call.
> 
> The call is made with no locks held. Architecture code is responsible

"The call is made with no locks held." -> "resctrl filesystem calls the
hook with no locks held."
(imperative)

> for any required locking.
> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---

Reinette