Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add bindings for AP1302

[Rob Herring]

On Mon, Aug 11, 2025 at 04:42:30PM -0400, Frank Li wrote:
> From: Anil Kumar Mamidala <anil.mamidala@xxxxxxxxxx>
> 
> The AP1302 is a standalone ISP for ON Semiconductor sensors, which can
> connect RAW sensors (AR0144).
> 
> Add corresponding DT bindings.
> 
> Signed-off-by: Anil Kumar Mamidala <anil.mamidala@xxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Stefan Hladnik <stefan.hladnik@xxxxxxxxx>
> Signed-off-by: Florian Rebaudo <frebaudo@xxxxxxxxxxx>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> Previous try:
> https://lore.kernel.org/linux-media/1631091372-16191-2-git-send-email-anil.mamidala@xxxxxxxxxx/
> 
> Change in v4:
> - base on discussion https://lore.kernel.org/imx/CAL_JsqLUj2h1OxUokOGFL34czroJnJ33cpvn9jO8b8=cu8Fz0g@xxxxxxxxxxxxxx/
>   change to use onnn,model property to descript connected raw sensor
> - Overall roll back to v2, move raw sensor information under "sensor" from
>   ports.
> - regs use enum [0, 1] to restrict address range
> - add supply name from sensor
> 
> Change in v3:
> - Move sensors under ports
> - use compatible string to indentify connected raw sensors
> - Add onnn,ar0144.yaml
> ---
>  .../devicetree/bindings/media/i2c/onnn,ap1302.yaml | 184 +++++++++++++++++++++
>  MAINTAINERS                                        |   8 +
>  2 files changed, 192 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..d66962d2eadca3f4d86c99a68d5ae7996bd1a522
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ap1302.yaml
> @@ -0,0 +1,184 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/onnn,ap1302.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor AP1302 Advanced Image Coprocessor
> +
> +maintainers:
> +  - Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> +  - Frank Li <Frank.Li@xxxxxxx>
> +
> +description:

You need a '>'

> +  The AP1302 is a standalone ISP for ON Semiconductor sensors. It interfaces to
> +  up to two RAW CMOS sensors over MIPI CSI-2 connections, processes the two
> +  video streams and outputs YUV frames to the host over a MIPI CSI-2 interface.
> +  Frames are output side by side or on two virtual channels.
> +
> +  The sensors must be identical. They are connected to the AP1302 on dedicated
> +  I2C buses, and are controlled by the AP1302 firmware. They are not accessible
> +  from the host.
> +
> +properties:
> +  compatible:
> +    const: onnn,ap1302
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description:
> +          Reference to the CLK clock.
> +
> +  enable-gpios:
> +    items:
> +      - description:
> +          Reference to the GPIO connected to the EN pin (active high).
> +
> +  reset-gpios:
> +    items:
> +      - description:
> +          Reference to the GPIO connected to the RST pin (active low).
> +
> +  standby-gpios:
> +    items:
> +      - description:
> +          Reference to the GPIO connected to the STANDBY pin (active high).
> +
> +  dvdd-supply: true
> +
> +  hmisc-supply: true
> +
> +  smisc-supply: true
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
> +    description: MIPI CSI-2 output interface to the host.
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            oneOf:
> +              - items:
> +                  - const: 1
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +
> +        required:
> +          - data-lanes
> +
> +  sensors:
> +    type: object
> +    additionalProperties: false
> +    description: List of connected sensors
> +
> +    properties:
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
> +      onnn,model:
> +        enum:
> +          - onnn,ar0144
> +          - onnn,ar0330
> +          - onnn,ar1335
> +        description:

You need a '>'

> +          Model of the connected sensors. Must be a valid compatible string.
> +
> +          If no sensor is connected, this property must no be specified, and
> +          the AP1302 can be used with it's internal test pattern generator.
> +
> +    patternProperties:
> +      "^sensor@[01]":

"^sensor@[01]$"

With those fixed,

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>