Re: [PATCH 3/3] dt-bindings: mips: lantiq: Add Lantiq platform binding

[Conor Dooley]

On Thu, Aug 14, 2025 at 06:31:42PM +0200, Aleksander Jan Bajkowski wrote:
> On 8/13/25 18:56, Conor Dooley wrote:
> > On Wed, Aug 13, 2025 at 04:21:34PM +0200, Aleksander Jan Bajkowski wrote:
> > > Document the top-level device tree binding for Lantiq MIPS-based SoCs
> > > 
> > > Signed-off-by: Aleksander Jan Bajkowski <olek2@xxxxx>
> > > ---
> > >   .../devicetree/bindings/mips/lantiq/soc.yaml  | 60 +++++++++++++++++++
> > >   1 file changed, 60 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/mips/lantiq/soc.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mips/lantiq/soc.yaml b/Documentation/devicetree/bindings/mips/lantiq/soc.yaml
> > > new file mode 100644
> > > index 000000000000..e1708cd9b07e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mips/lantiq/soc.yaml
> > > @@ -0,0 +1,60 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mips/lantiq/soc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Lantiq SoC based Platform
> > > +
> > > +maintainers:
> > > +  - Aleksander Jan Bajkowski <olek2@xxxxx>
> > > +
> > > +description:
> > > +  Devices with a Lantiq CPU shall have the following properties.
> > > +
> > > +properties:
> > > +  $nodename:
> > > +    const: "/"
> > > +  compatible:
> > > +    oneOf:
> > > +      - description: Boards with Lantiq Amazon-SE SoC
> > > +        items:
> > > +          - const: lantiq,ase
> > Half these entries you have added say "boards" but there are no boards
> > in them at all. Where are the boards? Only the homehub entry appears to
> > be complete.
> 
> Right now, I'm just adding one router with the Lantiq xRX200 SoC. The
> binding
> is prepared for adding more devices in the future. I'd like to add devices
> based on the xRX100 and xRX330 SoCs too. Should I remove the other SoCs from
> the list now?

Ye, I'd remove all of the unused SoCs.

Attachment: signature.asc
Description: PGP signature