Re: [PATCH v3 01/30] kho: init new_physxa->phys_bits to fix lockdep

From: Pasha Tatashin
Date: Thu Aug 14 2025 - 11:03:16 EST


On Thu, Aug 14, 2025 at 1:11 PM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:
>
> On Thu, Aug 07, 2025 at 01:44:07AM +0000, Pasha Tatashin wrote:
> > - physxa = xa_load_or_alloc(&track->orders, order, sizeof(*physxa));
> > - if (IS_ERR(physxa))
> > - return PTR_ERR(physxa);
>
> It is probably better to introduce a function pointer argument to this
> xa_load_or_alloc() to do the alloc and init operation than to open
> code the thing.

Agreed, but this should be a separate clean-up, this particular patch
is a hotfix that should land soon (it was separated from this this
series). Once it lands, we are going to do this clean-up.

Pasha