Re: [PATCH 0/3] Apple Silicon SMC RTC driver

From: Neal Gompa
Date: Thu Aug 14 2025 - 09:10:35 EST


On Tue, Aug 12, 2025 at 11:25 AM Sven Peter <sven@xxxxxxxxxx> wrote:
>
> Hi,
>
> Now that the core mfd device has been upstream I've prepared one of the
> child drivers that is still missing: RTC support.
> This driver is required to read and set the hardware clock and requires
> a reference to an additional NVMEM cell to store the offset and thus
> requires a device tree node.
>
> The series applies cleanly to 6.17-rc1 but is based on a tree with three
> additional commits to add the SMC nodes to the DTS which didn't make it
> into 6.17. You can just ignore that and pretend this is based on
> 6.17-rc1 since I'll take the dts update through my tree anyway.
>
> Next to this SMC child driver we're still working on an input/misc HID
> driver for the powerbutton, a hwmon driver for the various sensors and a
> power-supply driver to manage the batteries.
>
> Best,
>
> Sven
>
> Signed-off-by: Sven Peter <sven@xxxxxxxxxx>
> ---
> Hector Martin (1):
> rtc: Add new rtc-macsmc driver for Apple Silicon Macs
>
> Sven Peter (2):
> dt-bindings: rtc: Add Apple SMC RTC
> arm64: dts: apple: t8103,t600x,t8112: Add SMC RTC node
>
> .../devicetree/bindings/mfd/apple,smc.yaml | 9 ++
> .../devicetree/bindings/rtc/apple,smc-rtc.yaml | 35 +++++
> MAINTAINERS | 2 +
> arch/arm64/boot/dts/apple/t600x-die0.dtsi | 6 +
> arch/arm64/boot/dts/apple/t8103.dtsi | 6 +
> arch/arm64/boot/dts/apple/t8112.dtsi | 6 +
> drivers/mfd/macsmc.c | 1 +
> drivers/rtc/Kconfig | 11 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-macsmc.c | 141 +++++++++++++++++++++
> 10 files changed, 218 insertions(+)
> ---
> base-commit: 772c260c9c7f916c9a2508839df4f03fc19f3773
> change-id: 20250812-wip-smc-rtc-e856b6f24603
>

Series looks good to me, thanks for submitting them!

Reviewed-by: Neal Gompa <neal@xxxxxxxxx>


--
真実はいつも一つ!/ Always, there's only one truth!