Re: [PATCH net-next v4 1/4] net: phy: micrel: Start using PHY_ID_MATCH_MODEL

[Russell King (Oracle)]

On Thu, Aug 14, 2025 at 10:26:21AM +0200, Horatiu Vultur wrote:
> Start using PHY_ID_MATCH_MODEL for all the drivers.
> While at this add also PHY_ID_KSZ8041RNLI to micrel_tbl.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>

I'm not sure about this patch. You're subsituting a match that uses
the desired ID with a mask of 0x00fffff0 with PHY_ID_MATCH_MODEL(id)
which uses a mask of 0xfffffff0.

The commit description ought to explain why it is safe to match using
bits 31:24, whereas the old code was ignoring these bits.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!