Re: [PATCH net-next v4 2/4] net: phy: micrel: Introduce lanphy_modify_page_reg
From: Russell King (Oracle)
Date: Thu Aug 14 2025 - 05:27:17 EST
On Thu, Aug 14, 2025 at 10:26:22AM +0200, Horatiu Vultur wrote:
> As the name suggests this function modifies the register in an
> extended page. It has the same parameters as phy_modify_mmd.
> This function was introduce because there are many places in the
> code where the registers was read then the value was modified and
> written back. So replace all this code with this function to make
> it clear.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
Looks good to me.
Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!