Re: [PATCH v3 1/3] dt-bindings: sound: add bindings for pm4125 audio codec

[Krzysztof Kozlowski]

On Thu, Aug 14, 2025 at 01:14:47AM +0100, Alexey Klimov wrote:
> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
> It has TX and RX soundwire slave devices hence two files are added.
> 
> While at this, also add qcom,pm4125-codec compatible to pattern properties
> in mfd qcom,spmi-pmic schema so the devicetree for this audio block of
> PMIC can be validated properly.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml    |   7 +-
>  .../bindings/sound/qcom,pm4125-codec.yaml          | 134 +++++++++++++++++++++
>  .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml |  79 ++++++++++++
>  3 files changed, 219 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 078a6886f8b1e9ceb2187e988ce7c9514ff6dc2c..068f495645f6e849bd98b226c958ad67ba521dd5 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -137,7 +137,12 @@ patternProperties:
>  
>    "^audio-codec@[0-9a-f]+$":
>      type: object
> -    $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
> +    oneOf:
> +      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#

That's not the syntax present in display bindings I referred you to.

You want compatible as enum of:
 - qcom,pm8916-wcd-analog-codec
 - qcom,pm4125-codec

> +      - properties:
> +          compatible:
> +            contains:

No need for contains.

And this can be separate patch, because it targets different subsystem
maintainers.

Rest looks fine.

Best regards,
Krzysztof