Re: [RFC PATCH v2 02/25] sched/deadline: Do not access dl_se->rq directly

From: Juri Lelli
Date: Thu Aug 14 2025 - 04:31:40 EST


Hi,

On 31/07/25 12:55, Yuri Andriaccio wrote:

...

> @@ -1667,9 +1668,9 @@ void sched_init_dl_servers(void)
>
> WARN_ON(dl_server(dl_se));
>
> - dl_server_apply_params(dl_se, runtime, period, 1);
> -
> dl_se->dl_server = 1;
> + BUG_ON(dl_server_apply_params(dl_se, runtime, period, 1));

A WARN_ON(), with possibly a recover strategy, is usually to prefer.

Thanks,
Juri