Re: [PATCH v4 4/7] ALSA: usb-audio: us144mkii: Implement audio capture and decoding

[Takashi Iwai]

On Wed, 13 Aug 2025 15:15:15 +0200,
Šerif Rami wrote:
> 
> +void tascam_capture_work_handler(struct work_struct *work)
> +{
....
> +	while (atomic_read(&tascam->capture_active)) {
> +		size_t write_ptr, read_ptr, available_data;
> +		bool can_process;
> +
> +		{
> +			guard(spinlock_irqsave)(&tascam->lock);

Use scoped_guard().

> +		decode_tascam_capture_block(raw_block, decoded_block);
> +		process_capture_routing_us144mkii(tascam, decoded_block,
> +						  routed_block);
> +
> +		{
> +			guard(spinlock_irqsave)(&tascam->lock);

Ditto.


> +void capture_urb_complete(struct urb *urb)
> +{
....
> +	if (urb->actual_length > 0) {
> +		size_t write_ptr;
> +		size_t bytes_to_end;
> +
> +		{
> +			guard(spinlock_irqsave)(&tascam->lock);

Ditto.


thanks,

Takashi