Re: [PATCH v7 08/13] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex bindings

[Hans Zhang]

On 2025/8/14 03:08, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On 13/08/2025 11:12, Hans Zhang wrote:
> > On 2025/8/13 16:31, Rob Herring (Arm) wrote:
> > > EXTERNAL EMAIL
> > >
> > > On Wed, 13 Aug 2025 12:23:26 +0800, hans.zhang@xxxxxxxxxxx wrote:
> > > > From: Hans Zhang <hans.zhang@xxxxxxxxxxx>
> > > >
> > > > Document the bindings for CIX Sky1 PCIe Controller configured in
> > > > root complex mode with five root port.
> > > >
> > > > Supports 4 INTx, MSI and MSI-x interrupts from the ARM GICv3 controller.
> > > >
> > > > Signed-off-by: Hans Zhang <hans.zhang@xxxxxxxxxxx>
> > > > ---
> > > >    .../bindings/pci/cix,sky1-pcie-host.yaml      | 79 +++++++++++++++++++
> > > >    1 file changed, 79 insertions(+)
> > > >    create mode 100644 Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb: /: 'compatible' is a required property
> > >           from schema $id: http://devicetree.org/schemas/root-node.yaml#
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb: /: 'model' is a required property
> > >           from schema $id: http://devicetree.org/schemas/root-node.yaml#
> > >
> > > doc reference errors (make refcheckdocs):
> > >
> > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250813042331.1258272-9-hans.zhang@xxxxxxxxxxx
> > >
> > > The base for the series is generally the latest rc1. A different dependency
> > > should be noted in *this* patch.
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> > >
> > > pip3 install dtschema --upgrade
> > >
> > > Please check and re-submit after running the above command yourself. Note
> > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > > your schema. However, it must be unset to test all examples with your schema.
> >
> > Dear Rob,
> >
> > I'm very sorry. No errors were detected on my PC. I'll check my local
> > environment and fix this issue in the next version.
> >
> > If I have done anything wrong, please remind me.
>
> Your code is not correct. You are not supposed to have there root node.
> Please open ANY (most recent preferably) other binding and look how it
> is done there.

Dear Krzysztof,

Thank you very much for your reply.

I found a recent reference example, which will be fixed in the next version.

Documentation/devicetree/bindings/pci/sophgo,sg2044-pcie.yaml

Best regards,
Hans