Re: [PATCH v2 05/24] media: iris: Allow substate transition to load resources during output streaming

[Konrad Dybcio]

On 8/13/25 11:51 PM, Bryan O'Donoghue wrote:
> On 13/08/2025 10:37, Dikshita Agarwal wrote:
>> However, now after removing that restriction, the instance state can be
>> OUTPUT_STREAMING when firmware start is triggered and substate needs to
>> be moved to LOAD_RESOURCES.
>>
>> Fixes: 547f7b8c5090 ("media: iris: add check to allow sub states transitions")
> 
> If a restriction has been removed, has that restriction been marked as a 
> Fixes: ?
> 
> If not then we can't actually backport this fix as the dependency - the 
> restriction removal has not been marked for backport.

Please stop confusing fixes and backports..

If you're really paranoid about this commit getting autoselected, see
'noautosel' under this section:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Konrad

> 
> Please evaluate if the necessary change you have stipulated here has 
> been marked for backport with Fixes: and if so mention the appropriate 
> commit SHA in your commit log.
> 
> If you are referring to the commit immediately preceding this patch "Fix 
> buffer count reporting in internal buffer check" then again you should 
> mention that in the log so _which_ dependency you mean is clear.
> 
> If I were trying to follow this series on some kind of -stable kernel, I 
> don't think this commit log would reasonably tell me which depends I 
> need as an antecedent.
> 
> ---
> bod
> 
>