Re: [PATCH v2 1/3] media: dt-bindings: qcom,sm8550-iris: Add SM8750 video codec

From: Bryan O'Donoghue
Date: Wed Aug 13 2025 - 17:16:56 EST


On 12/08/2025 09:04, Krzysztof Kozlowski wrote:
On 12/08/2025 10:00, Krzysztof Kozlowski wrote:
On 12/08/2025 09:54, Dikshita Agarwal wrote:


On 8/4/2025 7:07 PM, Krzysztof Kozlowski wrote:
Add binding for Qualcom SM8750 Iris video codec, which comes with
significantly different powering up sequence than previous SM8650, thus
different clocks and resets. For consistency keep existing clock and
clock-names naming, so the list shares common part.

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
---
.../bindings/media/qcom,sm8750-iris.yaml | 186 +++++++++++++++++++++
1 file changed, 186 insertions(+)


Query:
Can the additional reset and clocks be accommodated in existing 8550-iris

No, different hardware. Although it is hardware from your domain and
your company, so I would assume you know the answer.
I guess I misread - I thought you want to re-use existing properties or
something like that, but you just want to create one huge binding?

No. Don't grow these unmaintainable patterns. We have been changing this
for some time already :/

Best regards,
Krzysztof

@Dikshita can you revert here are you happy with a new binding or requesting in-line changes in Iris - my reading here is a binding is justified.

@Krzysztof https://lore.kernel.org/linux-arm-msm/fb8f154b-3da4-4bee-82e1-3a1597a35c46@xxxxxxxxxx/

Are you sending a v3 here ?

I can also just add the OPP when applying this patch.

---
bod