Re: [PATCH v2] arm64: dts: qcom: sm8450: Fix address for usb controller node
From: Krzysztof Kozlowski
Date: Wed Aug 13 2025 - 14:42:38 EST
On 13/08/2025 18:09, Krishna Kurapati wrote:
> Correct the address in usb controller node to fix the following warning:
>
> Warning (simple_bus_reg): /soc@0/usb@a6f8800: simple-bus unit address
> format error, expected "a600000"
>
> Fixes: c5a87e3a6b3e ("arm64: dts: qcom: sm8450: Flatten usb controller node")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508121834.953Mvah2-lkp@xxxxxxxxx/
> Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> ---
> This change was tested with W=1 and the reported issue is not seen.
> Also didn't add RB Tag received from Neil Armstrong since there is a
> change in commit text.
Really? That is NOT the reason to drop people's review?
Apart from that, THERE IS NO change in commit txt, so dropping tags is
not justified by any means. It's really not acceptable.
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof