Re: [PATCH v2 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601

[Krzysztof Kozlowski]

On 13/08/2025 17:15, Ben Collins wrote:
> MCP9601 is a superset of MCP9600 and is supported by the driver.

There is no driver patch, so I cannot verify last part - about driver -
and I don't understand it. If it is already supported, doesn't it make
this patch redundant? Or did you wanted to say you are documenting
compatible being already used?


> 
> Signed-off-by: Ben Collins <bcollins@xxxxxxxxxx>


Where is the changelog? That's a v2.

No cover letter either...

> ---
>  .../bindings/iio/temperature/microchip,mcp9600.yaml         | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> index d2cafa38a5442..d8af0912ce886 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/temperature/microchip,mcp9600.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Microchip MCP9600 thermocouple EMF converter
> +title: Microchip MCP9600 and similar thermocouple EMF converters
>  
>  maintainers:
>    - Andrew Hepp <andrew.hepp@xxxxxxxxx>
> @@ -14,7 +14,9 @@ description:
>  
>  properties:
>    compatible:
> -    const: microchip,mcp9600
> +    enum:
> +      - microchip,mcp9600
> +      - microchip,mcp9601

If it is superset, why isn't this expressed with compatibility and fallback?

>  
>    reg:
>      maxItems: 1


Best regards,
Krzysztof