Re: [PATCH v2 1/3] i2c: add init_recovery() callback

[Gabor Juhos]

2025. 08. 13. 15:06 keltezéssel, Andy Shevchenko írta:
> On Wed, Aug 13, 2025 at 12:24:22PM +0200, Gabor Juhos wrote:
>> 2025. 08. 11. 22:17 keltezéssel, Andy Shevchenko írta:
>>> On Mon, Aug 11, 2025 at 09:49:55PM +0200, Gabor Juhos wrote:
> 
> ...
> 
>>>> This is needed for the 'i2c-pxa' driver in order to be able to fix
>>>> a long standing bug for which the fix will be implemented in a
> 
> The above left for some context for the below discussion.
> 
> ...
> 
>>> The first traditional question is why the generic recovery is not working.
>>
>> The details are in the driver specific patches. Should I write it all down here too?
> 
> Instead of the above paragraph, give a summary of your use case to answer 'why'
> it can not be done differently.

Ok.

> 
> ...
> 

...

>>
>> Originally, I have used the following solution:
>>
>>     if (bri->init_recovery)
>>         ret = bri->init_recovery(adap);
>>     else
>>         ret = i2c_gpio_init_recovery(adap);
> 
>>
> 
> Without this blank line...
> 
>>     if (ret)
>>         return ret;
> 
> ...this looks like the best compromise among proposed implementations.

Ok, I will use this in the next version.

Regards,
Gabor