"Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref"

[Shankari Anand]

On Fri, Aug 01, 2025 at 10:36:44AM +0200, Danilo Krummrich wrote:
> >
> >> NIT: Please don't top post. [1]
> >
> >> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
> >
> > Apologies, I’ll make sure to follow the interleaved style.
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> > [2] https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@xxxxxxxxxxxxxx/T/#u
> > [3] https://lore.kernel.org/rust-for-linux/20250716090712.809750-1-shankari.ak0208@xxxxxxxxx/
> > [4] https://lore.kernel.org/rust-for-linux/20250716091158.812860-1-shankari.ak0208@xxxxxxxxx/
> > [5] https://lore.kernel.org/rust-for-linux/20250716091827.816971-1-shankari.ak0208@xxxxxxxxx/
> > [6] https://lore.kernel.org/rust-for-linux/20250717072724.14602-1-shankari.ak0208@xxxxxxxxx/
> > [7] https://lore.kernel.org/rust-for-linux/20250717073108.14943-1-shankari.ak0208@xxxxxxxxx/
> 
> Ok, I see what happened. :)
> 
> I think you may have misunderstood the suggested of splitting things "by
> subsystem". Let's take [7] and [8] for instance.
> 
> In [7] you update all the samples, regardless of their subsystem affinity and
> [8] updates everything under rust/kernel/.
> 
> However, the idea was to send a separate patch per maintainers entry / tree,
> such that all patches can be picked in the corresponding tree.
> 
 I understood my mistake now. Thanks for clarifying!
 I'll split it out correctly and resend them.

> For instance, one patch should be everything that goes through driver-core:
> auxiliary, PCI (incl. sample), platform (incl. sample), device, devres.
> 
> Then you have another patch for only DMA (incl. sample), etc.
> 
 This particular patch in the series is restricted to inclusion of only gpu driver files.
 Can this be picked up separately or should I be merging it with any other driver?

> Can you please resend accordingly? Ideally, wait for -rc1 to be out, or base
> your changes on -next.
> 
> [8] https://lore.kernel.org/lkml/20250717073450.15090-1-shankari.ak0208@xxxxxxxxx/

Thanks and regards,
Shankari