Re: [PATCH net-next 5/7] staging: octeon: Convert to skb_dst_drop

[Greg KH]

On Tue, Aug 12, 2025 at 08:52:43AM -0700, Stanislav Fomichev wrote:
> Instead of doing dst_release and skb_dst_set, do skb_dst_drop which
> should do the right thing.
> 
> Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
> ---
>  drivers/staging/octeon/ethernet-tx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index 261f8dbdc382..0ba240e634a1 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -346,8 +346,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
>  	 * The skbuff will be reused without ever being freed. We must
>  	 * cleanup a bunch of core things.
>  	 */
> -	dst_release(skb_dst(skb));
> -	skb_dst_set(skb, NULL);
> +	skb_dst_drop(skb);
>  	skb_ext_reset(skb);
>  	nf_reset_ct(skb);
>  	skb_reset_redirect(skb);
> -- 
> 2.50.1
> 
> 

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>