Re: [PATCH] cxl: remove assignment from if condition in cxl_mem_get_poison

[Jonathan Cameron]

On Wed, 13 Aug 2025 17:25:54 +0530
darshanrathod475@xxxxxxxxx wrote:

> From: Darshan Rathod <darshanrathod475@xxxxxxxxx>
> 
> Refactor cxl_mem_get_poison() to assign the return value of
> ACQUIRE_ERR() before the conditional check, instead of performing the
> assignment inside the if condition. This resolves a checkpatch.pl
> warning ("do not use assignment in if condition") and improves
> readability.
> 
> Signed-off-by: Darshan Rathod <darshanrathod475@xxxxxxxxx>
See:
https://lore.kernel.org/all/20250813003821.2891532-1-alison.schofield@xxxxxxxxx/

Which stops checkpatch complaining about this.
Let's see where that discussion ends up before considering 'fixing' this.

Jonathan

> ---
>  drivers/cxl/core/mbox.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index fa6dd0c94656..9c5066631896 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1426,7 +1426,9 @@ int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len,
>  	int rc;
>  
>  	ACQUIRE(mutex_intr, lock)(&mds->poison.mutex);
> -	if ((rc = ACQUIRE_ERR(mutex_intr, &lock)))
> +
> +	rc = ACQUIRE_ERR(mutex_intr, &lock);
> +	if (rc)
>  		return rc;
>  
>  	po = mds->poison.list_out;