Re: [PATCH net-next v7 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

[Luo Jie]

On 8/13/2025 12:54 AM, Randy Dunlap wrote:
> On 8/12/25 7:10 AM, Luo Jie wrote:
> > diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
> > index a4434eb38950..6e56b022fc2d 100644
> > --- a/drivers/net/ethernet/qualcomm/Kconfig
> > +++ b/drivers/net/ethernet/qualcomm/Kconfig
> > @@ -60,6 +60,21 @@ config QCOM_EMAC
> >   	  low power, Receive-Side Scaling (RSS), and IEEE 1588-2008
> >   	  Precision Clock Synchronization Protocol.
> >   
> > +config QCOM_PPE
> > +	tristate "Qualcomm Technologies, Inc. PPE Ethernet support"
> > +	depends on HAS_IOMEM && OF
> > +	depends on COMMON_CLK
> > +	select REGMAP_MMIO
> > +	help
> > +	  This driver supports the Qualcomm Technologies, Inc. packet
> > +	  process engine (PPE) available with IPQ SoC. The PPE includes
> > +	  the ethernet MACs, Ethernet DMA (EDMA) and switch core that
>
> Please use ethernet or Ethernet consistently.

OK, I will update to use "Ethernet" consistently throughout the code.

> > +	  supports L3 flow offload, L2 switch function, RSS and tunnel
> > +	  offload.
> > +
> > +	  To compile this driver as a module, choose M here. The module
> > +	  will be called qcom-ppe.
> > +