Re: [PATCH] params: Replace deprecated strcpy() with strscpy()
From: Thorsten Blum
Date: Wed Aug 13 2025 - 05:33:58 EST
Hi Petr,
On 13. Aug 2025, at 10:59, Petr Pavlu wrote:
> Since the code already calculated the length of val and that it fits
> into kps->string, is there any advantage (or disadvantage) to using
> strscpy() over memcpy()?
strscpy() guarantees that the destination buffer 'kps->string' is always
NUL-terminated, even if the source 'val' is not. memcpy() just copies
the bytes as they are.
If it were guaranteed that 'val' is always NUL-terminated, memcpy()
would be fine too, but since param_set_copystring() is exported, we
probably can't make that assumption.
> I think this can go through the modules tree. I've CC'd the mailing
> list.
Thanks,
Thorsten