Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml

From: Krzysztof Kozlowski
Date: Wed Aug 13 2025 - 05:26:19 EST


On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
> +---
> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq cpu temperature sensor
> +
> +maintainers:
> + - Florian Eckert <fe@xxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: lantiq,cputemp
> +
> +required:
> + - compatible
> +

I think this reads and writs to some IOMEM space, so you really need
here 'reg'. That's the problem with such old bindings... binding is
broken, DTS is half-baked or non-existing, driver has 20 years.

BTW, why converting this old binding? Do you have any interest in
actually running MIPS?

I assume you did not check Rob's dt-convert branch to avoid
duplicated... because he did convert EXACTLY this binding. And more from
Lantiq.



Best regards,
Krzysztof