Re: [PATCH v8 4/4] can: m_can: Support pinctrl wakeup state

[Marc Kleine-Budde]

On 13.08.2025 09:44:35, Marc Kleine-Budde wrote:
> On 12.08.2025 11:10:25, Markus Schneider-Pargmann wrote:
> > am62 requires a wakeup flag being set in pinctrl when mcan pins acts as
> > a wakeup source. Add support to select the wakeup state if WOL is
> > enabled.
> 
> The driver makes already use of pinctrl_pm_select_default_state(dev),
> does it make sense to use it here, too?

Every suspend/resume cycle will overwrite the pinctrl setting with the
default one.

| int m_can_class_resume(struct device *dev)
| {
| [...]
| 	pinctrl_pm_select_default_state(dev);

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature