Re: [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC
From: Krzysztof Kozlowski
Date: Wed Aug 13 2025 - 02:15:13 EST
On 12/08/2025 20:25, Sven Peter wrote:
> +maintainers:
> + - Sven Peter <sven@xxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: apple,smc-rtc
> +
No resources except nvmem? This should be folded into the parent. Don't
create device node to instantiate drivers.
> + nvmem-cells:
> + items:
> + - description: 48bit RTC offset, specified in 32768 (2^15) Hz clock ticks
> +
> + nvmem-cell-names:
> + items:
> + - const: rtc_offset
> +
> +required:
> + - compatible
> + - nvmem-cells
> + - nvmem-cell-names
> +
> +additionalProperties: false
Missing example. If this is part of other device (like MFD), then the
one there should be extended here.
>
Best regards,
Krzysztof