Re: [PATCH v9 0/7] rust: add support for request_irq

From: Daniel Almeida
Date: Tue Aug 12 2025 - 15:18:55 EST


Hi Danilo,

> On 12 Aug 2025, at 16:07, Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> On Mon Aug 11, 2025 at 6:03 PM CEST, Daniel Almeida wrote:
>
> Applied to driver-core-testing, thanks!

Awesome, thanks everyone involved here :)

>
>> Alice Ryhl (1):
>> rust: irq: add &Device<Bound> argument to irq callbacks
>>
>> Daniel Almeida (6):
>> rust: irq: add irq module
>> rust: irq: add flags module
>
> [ Use expect(dead_code) for into_inner(), fix broken intra-doc link and
> typo. - Danilo ]

Right, I’ll consider inter-patch issues like this in the future, sorry.

[…]

>
> [ Remove expect(dead_code) from IrqRequest::new(), re-format macros and
> macro invocations to not exceed 100 characters line length. - Danilo ]
>
>> rust: pci: add irq accessors
>

How? rustfmt doesn’t format this, so I assume that you just manually
wrapped the lines in a suitable way?

— Daniel