Re: [PATCH] sfc: replace min/max nesting with clamp()
From: Joe Damato
Date: Tue Aug 12 2025 - 14:11:35 EST
On Tue, Aug 12, 2025 at 02:50:26PM +0800, Xichao Zhao wrote:
> The clamp() macro explicitly expresses the intent of constraining
> a value within bounds.Therefore, replacing min(max(a, b), c) with
> clamp(val, lo, hi) can improve code readability.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@xxxxxxxx>
> ---
> drivers/net/ethernet/sfc/efx_channels.c | 4 ++--
> drivers/net/ethernet/sfc/falcon/efx.c | 5 ++---
> drivers/net/ethernet/sfc/siena/efx_channels.c | 4 ++--
> 3 files changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Joe Damato <joe@xxxxxxx>