Re: [PATCH v1] ext4: fix incorrect function name in comment
From: Darrick J. Wong
Date: Tue Aug 12 2025 - 13:20:32 EST
On Tue, Aug 12, 2025 at 10:17:09AM +0800, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@xxxxxxxxxx>
>
> The comment mentions block_write_begin(), but the actual function
> called is ext4_block_write_begin().
> Fix the comment to match the real function name.
>
> Signed-off-by: Baolin Liu <liubaolin@xxxxxxxxxx>
Heh, that comment was copy-pasted too :/
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
--D
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index ed54c4d0f2f9..b0e3814f8502 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3155,7 +3155,7 @@ static int ext4_da_write_begin(const struct kiocb *iocb,
> folio_unlock(folio);
> folio_put(folio);
> /*
> - * block_write_begin may have instantiated a few blocks
> + * ext4_block_write_begin may have instantiated a few blocks
> * outside i_size. Trim these off again. Don't need
> * i_size_read because we hold inode lock.
> */
> --
> 2.39.2
>
>