Re: [PATCH RFC v2 1/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5

[Krzysztof Kozlowski]

On 12/08/2025 16:21, Konrad Dybcio wrote:
> On 8/6/25 2:38 PM, Krzysztof Kozlowski wrote:
>> Add Iris video codec to SM8750 SoC, which comes with significantly
>> different powering up sequence than previous SM8650, thus different
>> clocks and resets.  For consistency keep existing clock and clock-names
>> naming, so the list shares common part.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> ---
> 
> [...]
> 
>> +			iris_opp_table: opp-table {
>> +				compatible = "operating-points-v2";
>> +
>> +				opp-240000000 {
>> +					opp-hz = /bits/ 64 <240000000>;
>> +					required-opps = <&rpmhpd_opp_low_svs_d1>,
>> +							<&rpmhpd_opp_low_svs_d1>;
>> +				};
>> +
>> +				opp-338000000 {
>> +					opp-hz = /bits/ 64 <338000000>;
>> +					required-opps = <&rpmhpd_opp_low_svs>,
>> +							<&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-420000000 {
>> +					opp-hz = /bits/ 64 <420000000>;
>> +					required-opps = <&rpmhpd_opp_svs>,
>> +							<&rpmhpd_opp_svs>;
>> +				};
>> +
>> +				opp-444000000 {
>> +					opp-hz = /bits/ 64 <444000000>;
>> +					required-opps = <&rpmhpd_opp_svs_l1>,
>> +							<&rpmhpd_opp_svs_l1>;
>> +				};
>> +
>> +				opp-533333334 {
>> +					opp-hz = /bits/ 64 <533333334>;
>> +					required-opps = <&rpmhpd_opp_nom>,
>> +							<&rpmhpd_opp_nom>;
>> +				};
> 
> There's an additional OPP: 570 MHz @ NOM_L1
> 
> +Dmitry, Vikash, please make sure you're OK with the iommu entries


That opp has troubles with clock, so would need some fixed in videocc or
iris, AFAIK. Otherwise you will just PM OPP failures. I can add it
though, at the end  DTS should be independent of drivers. :)

Best regards,
Krzysztof