Re: [PATCH 5/8] ALSA: hrtimer: Avoid direct access to hrtimer clockbase

[Takashi Iwai]

On Tue, 12 Aug 2025 08:08:13 +0200,
Thomas Weißschuh wrote:
> 
> The field timer->base->get_time is a private implementation detail and
> should not be accessed outside of the hrtimer core.
> 
> Switch to the equivalent helper.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---
>  sound/core/hrtimer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/hrtimer.c b/sound/core/hrtimer.c
> index c364bd126ac8b311e3ce899e226ff9fd82c4485f..2d5f4d47071f79d7db24c8f004f0f4154808fdd8 100644
> --- a/sound/core/hrtimer.c
> +++ b/sound/core/hrtimer.c
> @@ -44,7 +44,7 @@ static enum hrtimer_restart snd_hrtimer_callback(struct hrtimer *hrt)
>  	}
>  
>  	/* calculate the drift */
> -	delta = ktime_sub(hrt->base->get_time(), hrtimer_get_expires(hrt));
> +	delta = ktime_sub(hrtimer_cb_get_time(hrt), hrtimer_get_expires(hrt));
>  	if (delta > 0)
>  		ticks += ktime_divns(delta, ticks * resolution);

Acked-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi