Re: [PATCH v2] loop: use vfs_getattr_nosec() for accurate file size

From: Christoph Hellwig
Date: Tue Aug 12 2025 - 04:51:36 EST


On Tue, Aug 12, 2025 at 12:42:44PM +0900, Damien Le Moal wrote:
> Since loff_t is "long long", so a signed type, I would keep this interface and
> add a negative error check in the 2 call sites for get_size(). That is simpler.

Not ethat the existing code already treats 0 as error for the
offset smaller than size case. I'm not arguing against and error
return, but that would require auditing all the call chains. And I'd
rather not multiplex it into the loff_t as that means people will forget
to handle it way too easily.