Re: [PATCH v2 1/2] dt-bindings: Pinefeat cef168 lens control board

From: Krzysztof Kozlowski
Date: Tue Aug 12 2025 - 03:14:13 EST


On 11/08/2025 23:31, Alexander Smirnov wrote:
> +

Subject: missing media prefix.

See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18


> +properties:
> + compatible:
> + enum:
> + - pinefeat,cef168
> +
> + reg:
> + maxItems: 1
> +
> + vcc-supply:
> + description: VDD 3v3 power supply


Property says VCC, description says VDD, datasheet says 5V (not 3.3V).

I guess this should be for the 5V case, no? If that's true, then I think
that 5V pin is not a controllable supply ever, because this product is
purely for RPi which has 5V pins directly tied to main power supply.


Best regards,
Krzysztof