Re: [PATCH 2/7] ALSA: usb-audio: us144mkii: Add PCM core infrastructure

[Takashi Iwai]

On Sun, 10 Aug 2025 14:49:53 +0200,
Šerif Rami wrote:
> 
> --- a/sound/usb/usx2y/us144mkii.h
> +++ b/sound/usb/usx2y/us144mkii.h
> @@ -1,38 +1,75 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  // Copyright (c) 2025 Šerif Rami <ramiserifpersia@xxxxxxxxx>
>  
> - #ifndef __US144MKII_H
> - #define __US144MKII_H
> +#ifndef __US144MKII_H
> +#define __US144MKII_H
>  
> - #include <linux/usb.h>
> - #include <sound/core.h>
> - #include <sound/initval.h>
> +#include <linux/usb.h>
> +#include <sound/core.h>
> +#include <sound/initval.h>
> +#include <sound/pcm.h>
>  
> - #define DRIVER_NAME "us144mkii"
> +#define DRIVER_NAME "us144mkii"
>  
>  /* --- USB Device Identification --- */
> - #define USB_VID_TASCAM 0x0644
> - #define USB_PID_TASCAM_US144 0x800f
> - #define USB_PID_TASCAM_US144MKII 0x8020
> +#define USB_VID_TASCAM 0x0644
> +#define USB_PID_TASCAM_US144 0x800f
> +#define USB_PID_TASCAM_US144MKII 0x8020

Another unneeded indentation changes.  Please fix in the first patch.
(Also for the rest.)


thanks,

Takashi