Re: [PATCH v2 1/4] dt-bindings: media: Add Sony IMX585 CMOS image sensor

[Krzysztof Kozlowski]

On 12/08/2025 04:47, Will Whang wrote:
> Hi Krzysztof,
> Reply inline.
> Thanks,
> Will Whang
> 
> On Mon, Aug 11, 2025 at 1:01 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On Sun, Aug 10, 2025 at 11:09:18PM +0100, Will Whang wrote:
>>> +description:
>>> +  IMX585 sensor is a Sony CMOS sensor with 4K and FHD outputs.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - sony,imx585
>>> +      - sony,imx585-mono
>>
>> I don't understand this second compatible. Is this different hardware?
>> Can you point me to "mono" datasheet?
>>
>> Your description should explain this. Commit msg as well, instead of
>> speaking about driver (in fact drop all driver related comments).
>>
> Mono version of this sensor is basically just removing the bayer
> filter, so the sensor itself actually doesn't know if it is color or
> mono and from my knowledge there are no registers programmed in the
> factory that will show the variant and model number. (That is why when
> the driver probing it only test blacklevel register because there are
> no ID registers)
> Originally in V1 patch I've made the switch between color and mono in
> dtoverlay config but reviewer comments is to move it to compatible
> string and not property.(https://lore.kernel.org/linux-media/20250703175121.GA17709@xxxxxxxxxxxxxxxxxxxxxxxxxx/)

You only partially answer and judging by mentioning driver below:


> 
> In this case, what would you recommend?
> 
> compatible:
>   enum:
>     - sony,imx585
>     - sony,imx585-mono
>   description: IMX585 has two variants, color and mono which the
> driver supports both.

... I still have doubts that you really understand what I am asking. Is
this one device or two different devices?


Best regards,
Krzysztof