Re: [PATCH net] bonding: don't set oif to bond dev when getting NS target destination
From: Jakub Kicinski
Date: Mon Aug 11 2025 - 23:15:21 EST
On Tue, 12 Aug 2025 02:04:53 +0000 Hangbin Liu wrote:
> On Mon, Aug 11, 2025 at 09:33:28AM -0700, Jakub Kicinski wrote:
> > On Mon, 11 Aug 2025 07:27:19 -0700 Jay Vosburgh wrote:
> > > Generically, I'm wondering if test updates should be separate
> > > patches from the functional changes as a general policy.
> >
> > Yes, not sure if we made it a hard requirement, but I think it's our
> > preference. It is the reason why we don't require cover letters for
> > submissions with 2 patches.
> >
> > Hangbin, please update config for bonding tests, looks like vlans
> > are not enabled there today.
>
> BTW, I'd like to change the bond config to modules. Because we can't unload
> the modules with current config. It that OK for you?
Yes. I'm not sure if any of the bonding tests need to load the modules
explicitly but we'll find out :) In general modules are fine for the CI.