Re: [PATCH v2] net: tun: replace strcpy with strscpy for ifr_name

From: Jakub Kicinski
Date: Mon Aug 11 2025 - 21:05:56 EST


On Mon, 11 Aug 2025 22:33:29 +0200 Miguel García wrote:
> Replace the strcpy() calls that copy the device name into ifr->ifr_name
> with strscpy() to avoid potential overflows and guarantee NULL termination.
>
> Destination is ifr->ifr_name (size IFNAMSIZ).
>
> Tested in QEMU (BusyBox rootfs):
> - Created TUN devices via TUNSETIFF helper
> - Set addresses and brought links up
> - Verified long interface names are safely truncated (IFNAMSIZ-1)
>
> v2:
> - Dropped third argument from strscpy(), inferred from field size.

Please don't post new patches in reply to old ones. Please read:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
there are multiple other problems with your submissions.
Please fix and repost.
--
pw-bot: cr