Re: [PATCH 1/4] genirq: Add irq_chip_(startup/shutdown)_parent
From: Inochi Amaoto
Date: Mon Aug 11 2025 - 18:34:02 EST
On Mon, Aug 11, 2025 at 04:37:30PM +0200, Thomas Gleixner wrote:
> On Thu, Aug 07 2025 at 19:23, Inochi Amaoto wrote:
>
> Please use 'function()' notation for functions. See
>
> https://www.kernel.org/doc/html/latest/process/maintainer-tip.html
>
> I'm sure I pointed you to this documented at least three times in the
> past. Do you think this was written for entertainment?
>
Yeah, I have remembered to add this brace for the function. It seems
like I have forgot to fix this when I do the rebase. I apology for it.
> > Add helper irq_chip_startup_parent and irq_chip_shutdown_parent. The
> > helper implement the default behavior in case irq_startup or irq_shutdown
> > is not implemented for the parent interrupt chip, which will fallback
> > to irq_chip_enable_parent or irq_chip_disable_parent if not available.
>
> Also please use the documented structure for change logs. Starting with
> 'Add' is just wrong. See Documentation.
>
OK, I will structure the changelog.
Regards,
Inochi.