Re: [PATCH net-next v2 5/5] dpll: zl3073x: Implement devlink flash callback

From: Randy Dunlap
Date: Mon Aug 11 2025 - 17:17:08 EST


Hi--

On 8/11/25 7:40 AM, Ivan Vecera wrote:
> +/**
> + * zl3073x_flash_update - Devlink flash update callback
> + * @devlink: devlink structure pointer
> + * @params: flashing parameters pointer
> + * @extack: netlink extack pointer to report errors
> + *
> + * Returns 0 in case of success or negative value otherwise

Preferably with a colon:

* Returns: 0 in case of success or negative value otherwise


> + */
> +static int
> +zl3073x_devlink_flash_update(struct devlink *devlink,
> + struct devlink_flash_update_params *params,
> + struct netlink_ext_ack *extack)
> +{
Thanks.
--
~Randy