Re: [PATCH v4] x86/fpu: Fix NULL dereference in avx512_status()

[Sohil Mehta]

On 8/11/2025 12:22 PM, Dave Hansen wrote:
> 
> The changelog also isn't really converging, so I gave it a go to
> rewrite it. Is this missing anything?
> 

Thank you! Your changelog covers the essentials and makes it concise.
The dual nature of x86_task_fpu() was making it hard to write for me.

A couple of typos:

> This is because the AVX-512 timestamp code uses x86_task_fpu() doesn't
								^^^but> check it for NULL.

Missing "but"

> If anyone ever wants to track kernel thread AVX-512 use, the can come
> back later and do it properly, separate from this bug fix.

s/the/they

> https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/commit/?h=testme&id=d61828dcbcff4ac80b91f5071ba6d21ef6c97347

It probably doesn't matter, but the documentation suggests ordering
Co-developed-by and Signed-off-by tags a bit differently.

"...every Co-developed-by: must be immediately followed by a
Signed-off-by: of the associated co-author."

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Example of a patch submitted by a Co-developed-by: author:

From: From Author <from@xxxxxxxxxxxxxxxxxx>

<changelog>

Co-developed-by: Random Co-Author <random@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Random Co-Author <random@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: From Author <from@xxxxxxxxxxxxxxxxxx>
Co-developed-by: Submitting Co-Author <sub@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Submitting Co-Author <sub@xxxxxxxxxxxxxxxxxxxx>