Re: [PATCH v2 06/12] media: rkvdec: Add RCB and SRAM support
From: Krzysztof Kozlowski
Date: Mon Aug 11 2025 - 10:05:08 EST
On 11/08/2025 15:54, Detlev Casanova wrote:
> On Monday, 11 August 2025 02:13:42 EDT Krzysztof Kozlowski wrote:
>> On 08/08/2025 22:03, Detlev Casanova wrote:
>>> - vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32));
>>> -
>>>
>>> irq = platform_get_irq(pdev, 0);
>>> if (irq <= 0)
>>>
>>> return -ENXIO;
>>>
>>> @@ -1204,6 +1217,10 @@ static int rkvdec_probe(struct platform_device
>>> *pdev)>
>>> return ret;
>>>
>>> }
>>>
>>> + rkvdec->sram_pool = of_gen_pool_get(pdev->dev.of_node, "sram", 0);
>>
>> Didn't you just add new ABI?
>
> Oh do you mean rkvdec_rcb_buf_count() ? I could indeed use that instead here.
No, I meant DT/OF ABI for "sram".
Best regards,
Krzysztof