Re: [PATCH] ublk: don't quiesce in ublk_ch_release

From: Jens Axboe
Date: Mon Aug 11 2025 - 10:03:50 EST



On Fri, 08 Aug 2025 15:44:43 -0600, Uday Shankar wrote:
> ublk_ch_release currently quiesces the device's request_queue while
> setting force_abort/fail_io. This avoids data races by preventing
> concurrent reads from the I/O path, but is not strictly needed - at this
> point, canceling is already set and guaranteed to be observed by any
> concurrently executing I/Os, so they will be handled properly even if
> the changes to force_abort/fail_io propagate to the I/O path later.
> Remove the quiesce/unquiesce calls from ublk_ch_release. This makes the
> writes to force_abort/fail_io concurrent with the reads in the I/O path,
> so make the accesses atomic.
>
> [...]

Applied, thanks!

[1/1] ublk: don't quiesce in ublk_ch_release
commit: 212c928d01e9ea1d1c46a114650b551da8ca823e

Best regards,
--
Jens Axboe