Re: [PATCH v1 3/5] dt-bindings: misc: Move amd,sbrmi.yaml from hwmon to misc

[Gupta, Akshay]

On 7/29/2025 11:59 AM, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 28/07/2025 08:10, Akshay Gupta wrote:
> > - AMD SB-RMI patches are moved from drivers/hwmon to
> >    drivers/misc to support additional functionality.
> >    Move the related bindings documentation files to misc.
> >
> > Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@xxxxxxx>
> Really? What was reviewed here exactly? Poor style of commit msg or that
> rename actually does rename?
>
> > Signed-off-by: Akshay Gupta <akshay.gupta@xxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/{hwmon => misc}/amd,sbrmi.yaml | 0
> We don't put bindings into MISC.

We moved the SB-RMI driver from hwmon to misc, and hence moved the 
binding documentation.

Referred the newly added yaml file, ti,fpc202.yaml through commit in the 
misc bindings.

If Documentation/devicetree/bindings/misc is not right path, can you 
please suggest the correct path for bindings for drivers in misc?

thank you.

> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
>
>
>
>
> Best regards,
> Krzysztof
Sorry, will take care of this.