Re: [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and handlers

[Daniel Almeida]

Hi Alice,

> On 11 Aug 2025, at 07:58, Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> 
> On Sun, Aug 10, 2025 at 09:32:16PM -0300, Daniel Almeida wrote:
>> This patch adds support for non-threaded IRQs and handlers through
>> irq::Registration and the irq::Handler trait.
>> 
>> Registering an irq is dependent upon having a IrqRequest that was
>> previously allocated by a given device. This will be introduced in
>> subsequent patches.
>> 
>> Tested-by: Joel Fernandes <joelagnelf@xxxxxxxxxx>
>> Tested-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
>> Signed-off-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
> 
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> 
>> diff --git a/rust/kernel/irq.rs b/rust/kernel/irq.rs
>> index d6306415f561f94a05b1c059eaa937b0b585471d..f7d89a46ad1894dda5a0a0f53683ff97f2359a4e 100644
>> --- a/rust/kernel/irq.rs
>> +++ b/rust/kernel/irq.rs
>> @@ -13,5 +13,11 @@
>> /// Flags to be used when registering IRQ handlers.
>> pub mod flags;
>> 
>> +/// IRQ allocation and handling.
>> +pub mod request;
> 
> Same comment here about removing `pub` from `mod request`.
> 
>> #[doc(inline)]
>> pub use flags::Flags;
>> +
>> +#[doc(inline)]
>> +pub use request::{Handler, IrqRequest, IrqReturn, Registration};
> 
> With `pub` removed above, you don't need doc(inline) here.
> 
> Alice
> 

This was not forgotten, i.e.: from the cover letter:

- Re-exported irq::flags::Flags through a "pub use" (Alice).
- Note: left the above as optional as it does not hurt to specify the full
path anyway. As a result, no modules were made private.

I chose Boqun’s idea, as we don’t have to enforce access through the
re-exports. Also, I was getting tons of “unreachable_pub” warnings
otherwise, FYI.

— Daniel