[PATCH v3 00/11] mm: vm_normal_page*() improvements

From: David Hildenbrand
Date: Mon Aug 11 2025 - 07:27:16 EST


Based on mm/mm-new from today.

Cleanup and unify vm_normal_page_*() handling, also marking the
huge zerofolio as special in the PMD. Add+use vm_normal_page_pud() and
cleanup that XEN vm_ops->find_special_page thingy.

There are plans of using vm_normal_page_*() more widely soon.

Briefly tested on UML (making sure vm_normal_page() still works as expected
without pte_special() support) and on x86-64 with a bunch of tests.
Cross-compiled for a variety of weird archs.

v2 -> v3:
* "mm/huge_memory: mark PMD mappings of the huge zero folio special"
-> Extend vm_normal_page_pmd() comment + patch description
-> Take care of copy_huge_pmd() checking for pmd_special().
* "powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel""
-> Added
* "mm/rmap: convert "enum rmap_level" to "enum pgtable_level""
-> Added
* "mm/memory: convert print_bad_pte() to print_bad_page_map()"
-> Consume level so we can keep the level indication through
pgtable_level_to_str().
-> Improve locking comments
* "mm/memory: factor out common code from vm_normal_page_*()"
-> Factor everything out into __vm_normal_page() and let it consume the
special bit + pfn (and the value+level for error reporting purposes)
-> Improve function docs
-> Improve patch description

v1 -> v2:
* "mm/memory: convert print_bad_pte() to print_bad_page_map()"
-> Don't use pgdp_get(), because it's broken on some arm configs
-> Extend patch description
-> Don't use pmd_val(pmdp_get()), because that doesn't work on some
m68k configs
* Added RBs

RFC -> v1:
* Dropped the highest_memmap_pfn removal stuff and instead added
"mm/memory: convert print_bad_pte() to print_bad_page_map()"
* Dropped "mm: compare pfns only if the entry is present when inserting
pfns/pages" for now, will probably clean that up separately.
* Dropped "mm: remove "horrible special case to handle copy-on-write
behaviour"", and "mm: drop addr parameter from vm_normal_*_pmd()" will
require more thought
* "mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd()"
-> Extend patch description.
* "fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio"
-> Extend patch description.
* "mm/huge_memory: mark PMD mappings of the huge zero folio special"
-> Remove comment from vm_normal_page_pmd().
* "mm/memory: factor out common code from vm_normal_page_*()"
-> Adjust to print_bad_page_map()/highest_memmap_pfn changes.
-> Add proper kernel doc to all involved functions
* "mm: introduce and use vm_normal_page_pud()"
-> Adjust to print_bad_page_map() changes.

Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Cc: Juergen Gross <jgross@xxxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Christian Brauner <brauner@xxxxxxxxxx>
Cc: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
Cc: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Mike Rapoport <rppt@xxxxxxxxxx>
Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Cc: Zi Yan <ziy@xxxxxxxxxx>
Cc: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
Cc: Nico Pache <npache@xxxxxxxxxx>
Cc: Ryan Roberts <ryan.roberts@xxxxxxx>
Cc: Dev Jain <dev.jain@xxxxxxx>
Cc: Barry Song <baohua@xxxxxxxxxx>
Cc: Jann Horn <jannh@xxxxxxxxxx>
Cc: Pedro Falcato <pfalcato@xxxxxxx>
Cc: Hugh Dickins <hughd@xxxxxxxxxx>
Cc: Oscar Salvador <osalvador@xxxxxxx>
Cc: Lance Yang <lance.yang@xxxxxxxxx>

David Hildenbrand (11):
mm/huge_memory: move more common code into insert_pmd()
mm/huge_memory: move more common code into insert_pud()
mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd()
fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio
mm/huge_memory: mark PMD mappings of the huge zero folio special
powerpc/ptdump: rename "struct pgtable_level" to "struct
ptdump_pglevel"
mm/rmap: convert "enum rmap_level" to "enum pgtable_level"
mm/memory: convert print_bad_pte() to print_bad_page_map()
mm/memory: factor out common code from vm_normal_page_*()
mm: introduce and use vm_normal_page_pud()
mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page()

arch/powerpc/mm/ptdump/8xx.c | 2 +-
arch/powerpc/mm/ptdump/book3s64.c | 2 +-
arch/powerpc/mm/ptdump/ptdump.h | 4 +-
arch/powerpc/mm/ptdump/shared.c | 2 +-
drivers/xen/Kconfig | 1 +
drivers/xen/gntdev.c | 5 +-
fs/dax.c | 47 +----
include/linux/mm.h | 20 +-
include/linux/pgtable.h | 27 +++
include/linux/rmap.h | 60 +++---
mm/Kconfig | 2 +
mm/huge_memory.c | 122 +++++------
mm/memory.c | 332 +++++++++++++++++++++---------
mm/pagewalk.c | 20 +-
mm/rmap.c | 56 ++---
tools/testing/vma/vma_internal.h | 18 +-
16 files changed, 421 insertions(+), 299 deletions(-)


base-commit: 53c448023185717d0ed56b5546dc2be405da92ff
--
2.50.1